Skip to content

upcoming: [DPS-33112] Add Streams empty state and Create Stream views #12235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mduda-akamai
Copy link
Contributor

@mduda-akamai mduda-akamai commented May 16, 2025

Description 📝

DataStream: Streams empty state, Create Stream placeholder

Changes 🔄

List any change(s) relevant to the reviewer.

  • empty state for Streams tab with Create Stream button
  • Create Stream button redirecting to datastream/streams/create
  • Create Stream view with placeholders for form

Target release date 🗓️

July 2025

Preview 📷

Before After
before after empty
after create stream

How to test 🧪

Prerequisites

(How to setup test environment)

  • navigate to datastream/streams, datastream/streams/create
  • click on the button in datastream/streams
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
➕ Adding a changeset
📱 Providing mobile support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mduda-akamai mduda-akamai force-pushed the feature/DPS-33112-add-streams-empty-state-and-create-stream-views branch from d44d503 to 2b7ebd6 Compare May 16, 2025 11:20
@mduda-akamai mduda-akamai force-pushed the feature/DPS-33112-add-streams-empty-state-and-create-stream-views branch from 2b7ebd6 to c66b91d Compare May 16, 2025 12:42
@mduda-akamai mduda-akamai marked this pull request as ready for review May 16, 2025 14:24
@mduda-akamai mduda-akamai requested a review from a team as a code owner May 16, 2025 14:24
@mduda-akamai mduda-akamai requested review from cpathipa, abailly-akamai, mikeZuber-akamai and skrol-akamai and removed request for a team May 16, 2025 14:24
@mduda-akamai mduda-akamai self-assigned this May 19, 2025
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with breaking down the PRs and applying Cloud Manager coding standards

Confirmed patterns + UI look good ✅

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 4 failing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
4 Failing599 Passing6 Skipped123m 47s

Details

Failing Tests
SpecTest
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » object storage end-to-end tests
rebuild-linode.spec.tsCloud Manager Cypress Tests→rebuild linode » rebuild linode
access-key.e2e.spec.tsCloud Manager Cypress Tests→object storage access key end-to-end tests » object storage access key end-to-end tests
bucket-create-multicluster.spec.tsCloud Manager Cypress Tests→Object Storage Multicluster Bucket create » Object Storage Multicluster Bucket create

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/linodes/rebuild-linode.spec.ts,cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/objectStorageMulticluster/bucket-create-multicluster.spec.ts"

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

4 participants